Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNS] Records batched operations #16984

Merged
merged 28 commits into from
Sep 23, 2024

Conversation

RebeccaTamachiro
Copy link
Contributor

Summary

PCX-12645

@RebeccaTamachiro RebeccaTamachiro requested a review from a team as a code owner September 20, 2024 14:56
Copy link

gitguardian bot commented Sep 20, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11021221 Triggered Generic High Entropy Secret 57508d0 astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret 57508d0 astro.config.mjs View secret
11021221 Triggered Generic High Entropy Secret 57508d0 astro.config.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions github-actions bot added product:dns Issues or PRs related to DNS size/m labels Sep 20, 2024
Copy link
Contributor

@daisyfaithauma daisyfaithauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RebeccaTamachiro RebeccaTamachiro merged commit 060e209 into production Sep 23, 2024
14 checks passed
@RebeccaTamachiro RebeccaTamachiro deleted the rebecca/dns-records-batch-operations branch September 23, 2024 11:15
elithrar pushed a commit that referenced this pull request Oct 15, 2024
* Create new page for DNS records batch operations

* Adjust pages order within how-to folder

* Fill in intro and add more to the outline

* Adjust pages order to ascending complexity and specificity

* Make Dash h3s more generic and fill in content placeholders

* More specific on UI capabilities and add different Free limits

* Fix typo

* Fill in Dash deletion section

* Fill in API intro and operations requirements following PM feedback

* Overall review and add execution order and fail API behavior

* Fill in Dashboard instructions for editing proxy status

* Remove use-cases section and change mixed status callout to Note

* Text review

* Reference batch option from subdomain setup instructions

* Reference batch option from the delete-all-records page

* Fix record limit

* Mention tags and comments are also supported and cross-link

* Process PM feedback

* Fix required fields for 'puts' and update example

* Update example

* More visible and detailed callout around propagation

* Update note with Eng feedback

* Replace TBDs with actual URL references

* Overall review and fix typo

* Remove specific blog link - to be added again later

* Improve manage DNS records page and link to batched option

* Overall review and improve text for clarity
maheshwarip pushed a commit that referenced this pull request Dec 2, 2024
* Create new page for DNS records batch operations

* Adjust pages order within how-to folder

* Fill in intro and add more to the outline

* Adjust pages order to ascending complexity and specificity

* Make Dash h3s more generic and fill in content placeholders

* More specific on UI capabilities and add different Free limits

* Fix typo

* Fill in Dash deletion section

* Fill in API intro and operations requirements following PM feedback

* Overall review and add execution order and fail API behavior

* Fill in Dashboard instructions for editing proxy status

* Remove use-cases section and change mixed status callout to Note

* Text review

* Reference batch option from subdomain setup instructions

* Reference batch option from the delete-all-records page

* Fix record limit

* Mention tags and comments are also supported and cross-link

* Process PM feedback

* Fix required fields for 'puts' and update example

* Update example

* More visible and detailed callout around propagation

* Update note with Eng feedback

* Replace TBDs with actual URL references

* Overall review and fix typo

* Remove specific blog link - to be added again later

* Improve manage DNS records page and link to batched option

* Overall review and improve text for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:dns Issues or PRs related to DNS size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants