Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node:url to built-in node.js runtime apis #17070

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 24, 2024

Adds the URL module which is missing from the nodejs compat documentation.

Copy link

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e68cf4d
Status: ✅  Deploy successful!
Preview URL: https://3e71a70b.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://yagiz-add-nodejs-url.cloudflare-docs-7ou.pages.dev

View logs

@anonrig
Copy link
Member Author

anonrig commented Sep 24, 2024

It seems adding the file doesn't add URL to the list in https://developers.cloudflare.com/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis. Any idea how to add it?

@KianNH
Copy link
Contributor

KianNH commented Sep 24, 2024

It seems adding the file doesn't add URL to the list in https://developers.cloudflare.com/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis. Any idea how to add it?

It will add it to the list: https://yagiz-add-nodejs-url.cloudflare-docs-7ou.pages.dev/workers/runtime-apis/nodejs/#built-in-nodejs-runtime-apis

Copy link

@anonrig anonrig merged commit 7c7a6c3 into production Sep 24, 2024
15 checks passed
@anonrig anonrig deleted the yagiz/add-nodejs-url branch September 24, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants