Better NextJS Image loader for Cloudflare Images #17658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maamokun
requested review from
dcpena,
renandincer,
third774 and
a team
as code owners
github-actions
bot
added
product:images
third774
approved these changes
Oct 23, 2024
dcpena
approved these changes
Oct 24, 2024
workers-devprod
added
the
contribution
|
Congratulations @maamokun, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm2nhj9a9116080cjxtao0f14w This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've improved the NextJS Image loader code for Cloudflare Images, as the previous version broke images in local development. I've also rewritten it in TypeScript.
Screenshots (optional)
None
Documentation checklist