Added notes for cache request hostnames #18634
Conversation
ToriLindsay
requested review from
irvinebroque,
jasnell,
mikenomitch,
GregBrimble and
a team
as code owners
Deploying cloudflare-docs with
|
| Latest commit: |
8f74b36
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7b1b8f49.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://tori-pcx6484-cache-hostname.cloudflare-docs-7ou.pages.dev |
|
Files with changes (up to 15)
|
| @@ -109,6 +109,10 @@ The `stale-while-revalidate` and `stale-if-error` directives are not supported w | |||
|
|
|||
| ::: | |||
|
|
|||
| :::note | |||
| Do not use dynamic or invalid hostnames in cache requests. This can cause DNS cache failures and latency. | |||
There was a problem hiding this comment.
I think we should be more explicit. We should say that the hostname used in the cache request should match your hostname.
And then instead of "DNS cache failures" I'd say "a DNS lookup" which will significantly increase latency.
There was a problem hiding this comment.
I think if they use "request.headers.host" that'd be the correct hostname to use in all cases? I could be wrong about this though
EDIT: Err... we don't need to specify this since they'll just be passing the whole request object in.
I might say "Do not override the hostname in the request or use a hostname that differs from your own"?
|
@mikenomitch @irvinebroque Thank you for the feedback! I updated the note with the details from Mike. An example could also be included if you think that's necessary to show it more explicitly? Let me know your thoughts. |
Added notes - Do not use dynamic or invalid hostnames in cache requests. This can cause DNS cache failures and latency.