-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update account owned tokens #18684
Update account owned tokens #18684
Conversation
1. Update description to reflect GA status 2. Add procedural instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 files reviewed, 1 total issue(s) found.
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments! @jhutchings1
Co-authored-by: Patricia Santa Ana <103445940+patriciasantaana@users.noreply.github.com>
Co-authored-by: Patricia Santa Ana <103445940+patriciasantaana@users.noreply.github.com>
Co-authored-by: Patricia Santa Ana <103445940+patriciasantaana@users.noreply.github.com>
Co-authored-by: Patricia Santa Ana <103445940+patriciasantaana@users.noreply.github.com>
Good q @jhutchings1 - if it's appearing in vNext but not on the existing site, that's a bug to the existing site. We're doing the site cutover on Monday, so the easiest path forward is to omit the link to that endpoint for now and add it in on Monday/Tuesday. Using the fully qualified link to the /api-next/ in the interim should also work, though. |
We can sit on this PR until next week if it makes life easier. |
@patriciasantaana We should be good to go with this one now that the API docs changes have shipped. Do you want to rereview? |
Congratulations @jhutchings1, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm4szw30606950cjs1klrf9lx This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Summary
👋🏻 I made some quick updates to the account owned tokens page to reflect:
One piece that I wasn't sure how to do properly was link to an API that's only documented in the beta docs site (at least I couldn't find it on the regular site). @crwaters16 not sure if you have thoughts on the best way to do that.
Screenshots (optional)
Documentation checklist