Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account owned tokens #18684

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Conversation

jhutchings1
Copy link
Contributor

Summary

👋🏻 I made some quick updates to the account owned tokens page to reflect:

  1. Update description to reflect GA status
  2. Add procedural instructions
  3. Sort the compatibility matrix alphabetically

One piece that I wasn't sure how to do properly was link to an API that's only documented in the beta docs site (at least I couldn't find it on the regular site). @crwaters16 not sure if you have thoughts on the best way to do that.

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

1. Update description to reflect GA status
2. Add procedural instructions
@jhutchings1 jhutchings1 requested a review from a team as a code owner December 11, 2024 16:53
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.

src/content/partials/fundamentals/account-owned-tokens.mdx Outdated Show resolved Hide resolved
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Copy link
Contributor

@patriciasantaana patriciasantaana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments! @jhutchings1

jhutchings1 and others added 4 commits December 11, 2024 15:55
Co-authored-by: Patricia Santa Ana <103445940+patriciasantaana@users.noreply.github.com>
Co-authored-by: Patricia Santa Ana <103445940+patriciasantaana@users.noreply.github.com>
Co-authored-by: Patricia Santa Ana <103445940+patriciasantaana@users.noreply.github.com>
Co-authored-by: Patricia Santa Ana <103445940+patriciasantaana@users.noreply.github.com>
@crwaters16
Copy link
Contributor

Good q @jhutchings1 - if it's appearing in vNext but not on the existing site, that's a bug to the existing site. We're doing the site cutover on Monday, so the easiest path forward is to omit the link to that endpoint for now and add it in on Monday/Tuesday. Using the fully qualified link to the /api-next/ in the interim should also work, though.

@jhutchings1
Copy link
Contributor Author

Good q @jhutchings1 - if it's appearing in vNext but not on the existing site, that's a bug to the existing site. We're doing the site cutover on Monday, so the easiest path forward is to omit the link to that endpoint for now and add it in on Monday/Tuesday. Using the fully qualified link to the /api-next/ in the interim should also work, though.

We can sit on this PR until next week if it makes life easier.

@jhutchings1
Copy link
Contributor Author

@patriciasantaana We should be good to go with this one now that the API docs changes have shipped. Do you want to rereview?

@patriciasantaana patriciasantaana merged commit c0cd39b into cloudflare:production Dec 17, 2024
6 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Dec 17, 2024
Copy link

holopin-bot bot commented Dec 17, 2024

Congratulations @jhutchings1, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm4szw30606950cjs1klrf9lx

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants