taskprov: Enforce param length prefixes #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
armfazh,
bhalleycf,
captain-mota,
chris-wood and
mendess
as code owners
mendess
requested changes
Nov 29, 2023
cjpatton
force-pushed
the
cjpatton/next-dap-12
branch
from
ef17992
to
76f6dd7
Compare
|
Addressed your comments and force-pushed the commit. |
mendess
approved these changes
Nov 29, 2023
cjpatton
force-pushed
the
cjpatton/next-dap-11
branch
from
62e036d
to
b34b025
Compare
Structs `VdafConfig`, `DpConfig`, and `QueryConfig` all include a length prefix for the type-specific parameters so that the struct can be decoded even if the type is not recognized. If the parameters don't fill the space indicated by the length prefix, then decoding should fail. This change ensures the length is enforced for recognized types. It unifies the decoding logic across draft02 and draft07 (the former does not have the length prefix).
cjpatton
force-pushed
the
cjpatton/next-dap-12
branch
from
76f6dd7
to
26ad064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #350.
Stacked on #439.
Structs
VdafConfig,DpConfig, andQueryConfigall include a length prefix for the type-specific parameters so that the struct can be decoded even if the type is not recognized. If the parameters don't fill the space indicated by the length prefix, then decoding should fail. This change ensures the length is enforced for recognized types. It unifies the decoding logic across draft02 and draft07 (the former does not have the length prefix).