Remove DapVersion from DapMediaType parsing #689
+93
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendess
requested review from
bhalleycf,
cjpatton,
fisherdarling,
cbranch,
lbaquerofierro,
Noah-Kennedy and
RageKnify
as code owners
mendess
force-pushed
the
mendess/refactor-dap-req-2
branch
from
ce626b5
to
570dfc7
Compare
mendess
force-pushed
the
mendess/remove-version-from-dap-media-type
branch
from
2dfd8eb
to
888cfef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can be confident these media types are somewhat stable from now on