Coalesce requests to KV #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendess
requested review from
fisherdarling,
cbranch,
lbaquerofierro,
Noah-Kennedy and
RageKnify
as code owners
mendess
force-pushed
the
mendess/coalesce
branch
2 times, most recently
from
98b51be
to
62bfaab
Compare
mendess
force-pushed
the
mendess/coalesce
branch
2 times, most recently
from
cfd31c4
to
3138c92
Compare
mendess
force-pushed
the
mendess/coalesce
branch
3 times, most recently
from
ca3c9e4
to
65e2f29
Compare
mendess
force-pushed
the
mendess/coalesce
branch
from
65e2f29
to
5c2a9fd
Compare
mendess
force-pushed
the
mendess/coalesce
branch
4 times, most recently
from
ab6d381
to
1750d54
Compare
armfazh
approved these changes
Nov 13, 2024
crates/daphne-server/src/storage_proxy_connection/kv/request_coalescer.rs
Outdated
Show resolved
Hide resolved
crates/daphne-server/src/storage_proxy_connection/kv/request_coalescer.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+95
to
+98
| let op_key = OperationKey { | ||
| op_id: operation_id::of::<F, Fut, R, E>(), | ||
| key: key.clone(), | ||
| }; |
There was a problem hiding this comment.
can the op_key variable be defined before the loop?
There was a problem hiding this comment.
That results in an additional clone when passing it to the ResponseSender
| type CoalescedValue = | ||
| Result<Option<Marc<dyn Any + Send + Sync>>, CoalesceError<dyn Any + Send + Sync>>; | ||
|
|
||
| /// The send half to be used by the `executor` to send the result of it's computation to the |
There was a problem hiding this comment.
Suggested change
| /// The send half to be used by the `executor` to send the result of it's computation to the | |
| /// The send have to be used by the `executor` to send the result of it's computation to the |
There was a problem hiding this comment.
This is actually correct. A channel has two parts, the sending part and the receiving part, commonly referred to as the sending and receiving halves
mendess
force-pushed
the
mendess/coalesce
branch
from
1750d54
to
a8cea45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best viewed commit by commit.