Merge pull request #93 from cloudflare/clean-up-peer-connection-creation

Clean up RTCPeerConnection creation
cloudflare · Aug 21, 2024 · 4af2783 · 4af2783
2 parents 4e5bbe8 + 9ce8b1a
commit 4af2783
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/app/utils/rxjs/RxjsPeer.client.ts b/app/utils/rxjs/RxjsPeer.client.ts
@@ -60,8 +60,9 @@ export class RxjsPeer {
 			let peerConnection: RTCPeerConnection
 			const setup = () => {
 				peerConnection?.close()
-				peerConnection = createPeerConnection({
+				peerConnection = new RTCPeerConnection({
 					iceServers: config.iceServers,
+					bundlePolicy: 'max-bundle',
 				})
 				peerConnection.addEventListener('connectionstatechange', () => {
 					if (
@@ -526,17 +527,6 @@ export class RxjsPeer {
 	}
 }
 
-function createPeerConnection(
-	configuration: RTCConfiguration = {
-		iceServers: [{ urls: 'stun:stun.cloudflare.com:3478' }],
-		bundlePolicy: 'max-bundle',
-	}
-) {
-	const pc = new RTCPeerConnection(configuration)
-
-	return pc
-}
-
 async function resolveTrack(
 	peerConnection: RTCPeerConnection,
 	compare: (t: RTCRtpTransceiver) => boolean,