Split error logging from details #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
third774
requested review from
astroza,
renandincer,
nils-ohlmeier and
rcccf
nils-ohlmeier
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple more spots to capture some data for debugging. My theory for the mystery user/users leaving is that our cleanup function is removing users when it shouldn't be, and they immediately reconnect. I've added logging so we can see the websocket states when the cleanup runs since this is how partyserver determines which connections to return in
getConnections()See https://github.com/threepointone/partyserver/blob/main/packages/partyserver/src/connection.ts#L167-L183