don't broadcast state immediately onClose #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
force-pushed
the
delay-on-close-broadcast
branch
from
d19f028 to
b0253d4
Compare
threepointone
commented
Aug 9, 2024
| @@ -34,9 +34,9 @@ export class ChatRoom extends Server<Env> { | |||
| ) | |||
| ) | |||
|
|
|||
| if (!this.ctx.storage.getAlarm()) { | |||
| if (!(await this.ctx.storage.getAlarm())) { | |||
There was a problem hiding this comment.
fml. this would have been caught with a lint rule. I'll work on adding a better lint setup soon.
threepointone
commented
Aug 9, 2024
| // start the alarm to broadcast state every 30 seconds | ||
| this.ctx.storage.setAlarm(30000) | ||
| this.ctx.storage.setAlarm(Date.now() + 30000) |
There was a problem hiding this comment.
augh. maybe this should always accept only Dates, it's to oeasy to screw up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.