Fix Windows server shutdown #425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grvzard
commented
Oct 12, 2024
| let shutdown_type = server_runtime.get_handle().block_on(self.main_loop()); | ||
| #[cfg(windows)] | ||
| let shutdown_type = ShutdownType::Graceful; |
There was a problem hiding this comment.
the server will shut down immediately if we don't block it.
Grvzard
force-pushed
the
grvz/upstream-win-support
branch
from
63019c0 to
4d95426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The port from #344 was not complete, the first commit finished it.The second commit fixes a bug from previous work.
Now it works.
EDIT: rebased.