Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pingora tutorial start added #461

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

HasturDev
Copy link

I created the folder and a start.md so that you could look it over and decide if this is the type of tutorial you would want for pingora

@HasturDev
Copy link
Author

The intent of this push is to make sure that you guys are happy with how the tutorial is written.
I will generally write the rest of the tutorials in the same way so if there's any changes you want made or updates then it will be helpful when I write the rest of them.
I've also added all of the stand alone files for you guys so you can determine if there's more code in each file that you would want to add because you want me to talk about that specific thing

… to have the emphasis be correct and no lower statement is larger than the statement that it's explicitely supposed to be inside of
@johnhurt johnhurt self-assigned this Nov 15, 2024
moved code to it's correct location within the start.md file
@HasturDev
Copy link
Author

@johnhurt what changed that made this pass checks?

@johnhurt
Copy link
Contributor

It looks like it was one of log's dependencies that introduced a feature incompatible with our msrv. We had to fix it internally, and you reap the benefits 😛

@eaufavor eaufavor added the documentation Improvements or additions to documentation label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants