Refactor Server customize shutdown and signals to support embedding #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriswuollett
force-pushed
the
signal-handling-fn
branch
2 times, most recently
from
0ae925f to
6773af5
Compare
…ior. This change supports building a server that can run Pingora without it calling std::process::exit during shutdown.
kriswuollett
force-pushed
the
signal-handling-fn
branch
from
6773af5 to
11881c5
Compare
andrewhavck
requested changes
Dec 24, 2024
| GracefulTerminate, | ||
| FastShutdown, | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add doc comments for these public types.
| @@ -306,14 +362,25 @@ impl Server { | |||
| } | |||
| } | |||
|
|
|||
| /// Start the server using [Self::run] and default [RunArgs]. | |||
| #[allow(unused_mut)] // TODO: May not need to keep mut self in interface | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change currently aims to minimize the code diff. Still need to test for my use case.
Fixes #492