Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use publicURI for reports #1000

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Use publicURI for reports #1000

merged 2 commits into from
Jun 10, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.59.0-31-g963dee8
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Jun 10, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   86.69m ± 2%   87.34m ± 3%       ~ (p=0.739 n=10)
CheckRules-4    87.21m ± 0%   87.06m ± 0%       ~ (p=0.353 n=10)
geomean         86.95m        87.20m       +0.30%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   53.91Mi ± 0%   53.91Mi ± 0%       ~ (p=0.853 n=10)
CheckRules-4    84.07Mi ± 0%   84.07Mi ± 0%       ~ (p=0.739 n=10)
geomean         67.32Mi        67.32Mi       -0.00%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   435.0k ± 0%   435.0k ± 0%       ~ (p=0.753 n=10)
CheckRules-4    879.7k ± 0%   879.7k ± 0%       ~ (p=0.670 n=10)
geomean         618.6k        618.6k       -0.00%

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (f6c81df) to head (963dee8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
+ Coverage   94.14%   94.35%   +0.21%     
==========================================
  Files          95       95              
  Lines        9618     9592      -26     
==========================================
- Hits         9055     9051       -4     
+ Misses        402      382      -20     
+ Partials      161      159       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 7f42c89 into main Jun 10, 2024
20 checks passed
@prymitive prymitive deleted the uris branch June 10, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants