Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suggest humanize on printf #1001

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Don't suggest humanize on printf #1001

merged 1 commit into from
Jun 11, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.60.0-1-g0670cb7
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Jun 11, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   88.18m ± 1%   86.91m ± 1%  -1.44% (p=0.004 n=10)
CheckRules-4    88.63m ± 1%   88.12m ± 2%       ~ (p=0.218 n=10)
geomean         88.41m        87.51m       -1.01%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   53.91Mi ± 0%   53.91Mi ± 0%       ~ (p=0.481 n=10)
CheckRules-4    84.06Mi ± 0%   84.05Mi ± 0%  -0.01% (p=0.007 n=10)
geomean         67.32Mi        67.32Mi       -0.00%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   435.0k ± 0%   435.0k ± 0%       ~ (p=0.403 n=10)
CheckRules-4    879.7k ± 0%   879.1k ± 0%  -0.06% (p=0.000 n=10)
geomean         618.6k        618.4k       -0.03%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (7f42c89) to head (65c323e).

Current head 65c323e differs from pull request most recent head 0670cb7

Please upload reports for the commit 0670cb7 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
- Coverage   94.35%   94.35%   -0.01%     
==========================================
  Files          95       95              
  Lines        9592     9590       -2     
==========================================
- Hits         9051     9049       -2     
  Misses        382      382              
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit a8bb763 into main Jun 11, 2024
20 checks passed
@prymitive prymitive deleted the printf branch June 11, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants