Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor git history parsing #1009

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Refactor git history parsing #1009

merged 1 commit into from
Jun 21, 2024

Conversation

prymitive
Copy link
Collaborator

When running pint ci on a branch with merge commits these commits would make it look like there were more changes than in the actual diff.

When running pint ci on a branch with merge commits these commits would make it look like there were more changes than in the actual diff.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.60.0-17-g6a13b5a
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   107.1m ± 0%   107.0m ± 6%       ~ (p=0.971 n=10)
CheckRules-4    95.92m ± 1%   95.82m ± 0%       ~ (p=0.247 n=10)
geomean         101.4m        101.3m       -0.08%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   53.95Mi ± 0%   53.95Mi ± 0%       ~ (p=0.796 n=10)
CheckRules-4    84.04Mi ± 0%   84.04Mi ± 0%       ~ (p=0.739 n=10)
geomean         67.33Mi        67.33Mi       +0.00%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   434.9k ± 0%   434.9k ± 0%       ~ (p=0.810 n=10)
CheckRules-4    877.7k ± 0%   877.7k ± 0%       ~ (p=0.781 n=10)
geomean         617.8k        617.8k       -0.00%

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.34%. Comparing base (847bc01) to head (6a13b5a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
- Coverage   94.35%   94.34%   -0.01%     
==========================================
  Files          95       95              
  Lines        9590     9575      -15     
==========================================
- Hits         9049     9034      -15     
  Misses        382      382              
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 6162d89 into main Jun 21, 2024
20 checks passed
@prymitive prymitive deleted the merges branch June 21, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants