Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable perfsprint in golangci-lint #1011

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Enable perfsprint in golangci-lint #1011

merged 1 commit into from
Jun 24, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.60.0-21-g23188dc
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   108.2m ± 1%   108.5m ± 3%       ~ (p=0.393 n=10)
CheckRules-4    96.83m ± 1%   97.18m ± 3%       ~ (p=0.315 n=10)
geomean         102.4m        102.7m       +0.31%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   53.95Mi ± 0%   53.95Mi ± 0%       ~ (p=0.853 n=10)
CheckRules-4    84.05Mi ± 0%   84.04Mi ± 1%       ~ (p=0.684 n=10)
geomean         67.34Mi        67.33Mi       -0.00%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   434.9k ± 0%   434.9k ± 0%       ~ (p=0.954 n=10)
CheckRules-4    877.7k ± 0%   877.7k ± 1%       ~ (p=0.670 n=10)
geomean         617.8k        617.8k       +0.00%

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.34%. Comparing base (a6e48b7) to head (23188dc).

Files Patch % Lines
cmd/pint/ci.go 50.00% 3 Missing ⚠️
internal/config/repository.go 81.81% 2 Missing ⚠️
cmd/pint/watch.go 50.00% 1 Missing ⚠️
internal/reporter/gitlab.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          95       95           
  Lines        9575     9575           
=======================================
  Hits         9034     9034           
  Misses        382      382           
  Partials      159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit ac55817 into main Jun 24, 2024
20 checks passed
@prymitive prymitive deleted the perfsprint branch June 24, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants