Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mark rule/for as online #1035

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Don't mark rule/for as online #1035

merged 1 commit into from
Jul 18, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.62.1-11-g56b9386
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (cc064e7) to head (56b9386).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files          96       96           
  Lines        9816     9816           
=======================================
  Hits         9284     9284           
  Misses        376      376           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   38.23m ± 4%   38.38m ± 6%       ~ (p=0.393 n=10)
CheckRules-4     8.501 ± 2%    8.496 ± 2%       ~ (p=0.739 n=10)
geomean         570.1m        571.0m       +0.17%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.39Mi ± 0%   27.39Mi ± 0%       ~ (p=0.644 n=10)
CheckRules-4    940.6Mi ± 0%   940.9Mi ± 0%       ~ (p=0.912 n=10)
geomean         160.5Mi        160.5Mi       +0.02%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.6k ± 0%   131.6k ± 0%       ~ (p=0.614 n=10)
CheckRules-4    13.94M ± 0%   13.95M ± 0%       ~ (p=0.739 n=10)
geomean         1.354M        1.355M       +0.01%

@prymitive prymitive merged commit b9a4ba8 into main Jul 18, 2024
20 checks passed
@prymitive prymitive deleted the rule_for branch July 18, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants