-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor github reporer to use common comments code #1037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request was validated by pint.
✔️ No problems found
Stats
Stat | Value |
---|---|
Version | v0.62.1-25-g4bb0c3e |
Number of rules parsed | 4 |
Number of rules checked | 0 |
Number of problems found | 0 |
Number of offline checks | 0 |
Number of online checks | 0 |
Checks duration | 0 |
Problems
No problems reported
Benchmark diff:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
+ Coverage 94.58% 94.68% +0.10%
==========================================
Files 96 96
Lines 9816 9818 +2
==========================================
+ Hits 9284 9296 +12
+ Misses 376 366 -10
Partials 156 156 ☔ View full report in Codecov by Sentry. |
e2f787f
to
ddd704d
Compare
.github/pint/rules/1.yml
Outdated
@@ -6,7 +6,7 @@ groups: | |||
for: 0s | |||
|
|||
- alert: Service Is Down | |||
expr: up{job="abc"} == 0 | |||
expr: up{job="abc} == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛑 Bug reported by pint rule/label check.
priority
label is required.
ℹ️ To see documentation covering this check and instructions on how to resolve it click here.
.github/pint/rules/1.yml
Outdated
@@ -6,7 +6,7 @@ groups: | |||
for: 0s | |||
|
|||
- alert: Service Is Down | |||
expr: up{job="abc"} == 0 | |||
expr: up{job="abc} == 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛑 Fatal reported by pint promql/syntax check.
Prometheus failed to parse the query with this PromQL error: unterminated quoted string.
Click here for PromQL documentation.
ℹ️ To see documentation covering this check and instructions on how to resolve it click here.
57dca9a
to
6600e2b
Compare
This pint run would create 2 comment(s), which is more than the limit configured for pint (1). |
No description provided.