Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom rule for promql/range_query #1076

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Allow custom rule for promql/range_query #1076

merged 1 commit into from
Aug 20, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Aug 20, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   40.32m ± 5%   39.97m ± 3%       ~ (p=0.631 n=10)
CheckRules-4     8.519 ± 2%    8.530 ± 2%       ~ (p=0.853 n=10)
geomean         586.1m        583.9m       -0.38%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.41Mi ± 0%   27.41Mi ± 0%       ~ (p=0.631 n=10)
CheckRules-4    975.2Mi ± 0%   977.1Mi ± 0%  +0.20% (p=0.023 n=10)
geomean         163.5Mi        163.7Mi       +0.10%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.9k ± 0%   131.9k ± 0%       ~ (p=0.666 n=10)
CheckRules-4    14.17M ± 0%   14.18M ± 0%  +0.11% (p=0.000 n=10)
geomean         1.367M        1.368M       +0.05%

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (afc1fbf) to head (d642795).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   94.78%   94.80%   +0.02%     
==========================================
  Files          99      100       +1     
  Lines       10004    10043      +39     
==========================================
+ Hits         9482     9521      +39     
  Misses        366      366              
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.64.0-31-gd642795
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@prymitive prymitive force-pushed the range_query branch 3 times, most recently from 4caf3fd to 86393c1 Compare August 20, 2024 15:36
@prymitive prymitive merged commit fafd97a into main Aug 20, 2024
20 checks passed
@prymitive prymitive deleted the range_query branch August 20, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants