Allow matching on rule state #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark diff: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
+ Coverage 94.84% 94.89% +0.04%
==========================================
Files 100 102 +2
Lines 10086 10184 +98
==========================================
+ Hits 9566 9664 +98
Misses 365 365
Partials 155 155 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request was validated by pint.
✔️ No problems found
Stats
| Stat | Value |
|---|---|
| Version | v0.64.0-43-g8c3a9ab |
| Number of rules parsed | 4 |
| Number of rules checked | 4 |
| Number of problems found | 0 |
| Number of offline checks | 0 |
| Number of online checks | 0 |
| Checks duration | 0 |
Problems
No problems reported
prymitive
force-pushed
the
state
branch
3 times, most recently
from
2ffe5a2
to
0c5f1b5
Compare
.github/pint/rules/1.yml
Outdated
| @@ -3,7 +3,7 @@ groups: | |||
| rules: | |||
| - alert: Service Is Down | |||
| expr: up == 0 | |||
| for: 0s | |||
| for: 0m | |||
There was a problem hiding this comment.
ℹ️ Information reported by pint alerts/for check.
0m is the default value of for, consider removing this redundant line.
ℹ️ To see documentation covering this check and instructions on how to resolve it click here.
prymitive
force-pushed
the
state
branch
3 times, most recently
from
f8b6ef6
to
c9729a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.