Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive reports from promq/regexp #783

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix false positive reports from promq/regexp #783

merged 1 commit into from
Nov 17, 2023

Conversation

prymitive
Copy link
Collaborator

Fixes #782.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.49.1-7-gb13f7b9
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8e456d8) 94.15% compared to head (b13f7b9) 94.11%.

Files Patch % Lines
internal/checks/promql_regexp.go 37.50% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   94.15%   94.11%   -0.05%     
==========================================
  Files          91       91              
  Lines        9519     9526       +7     
==========================================
+ Hits         8963     8965       +2     
- Misses        419      423       +4     
- Partials      137      138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 373e392 into main Nov 17, 2023
19 of 20 checks passed
@prymitive prymitive deleted the issue-782 branch November 17, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regexp mode modifier not detected
2 participants