Merge pull request #2880 from cloudflare/fix-ci-assertions-p2

test: fix some broken assertions
cloudflare · Oct 25, 2023 · 03c6190 · 03c6190
2 parents 6393670 + bf0952c
commit 03c6190
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/internal/sdkv2provider/resource_cloudflare_access_identity_provider_test.go b/internal/sdkv2provider/resource_cloudflare_access_identity_provider_test.go
@@ -418,7 +418,6 @@ resource "cloudflare_access_identity_provider" "%[2]s" {
 		client_secret  = "test"
 		directory_id   = "directory"
 		support_groups = true
-		conditional_access_enabled = true
 	}
 	scim_config {
 		enabled                  = true
@@ -440,7 +439,6 @@ resource "cloudflare_access_identity_provider" "%[2]s" {
 		client_secret  = "test2"
 		directory_id   = "directory"
 		support_groups = true
-		conditional_access_enabled = true
 	}
 	scim_config {
 		enabled                  = true
@@ -462,7 +460,6 @@ resource "cloudflare_access_identity_provider" "%[2]s" {
 		client_secret  = "test"
 		directory_id   = "directory"
 		support_groups = true
-		conditional_access_enabled = true
 	}
 }`, accountID, name)
 }
diff --git a/internal/sdkv2provider/resource_cloudflare_certificate_pack_test.go b/internal/sdkv2provider/resource_cloudflare_certificate_pack_test.go
@@ -106,7 +106,7 @@ func TestAccCertificatePack_WaitForActive(t *testing.T) {
 					resource.TestCheckResourceAttr(name, "type", "advanced"),
 					resource.TestCheckResourceAttr(name, "hosts.#", "2"),
 					resource.TestCheckResourceAttr(name, "validation_method", "txt"),
-					resource.TestCheckResourceAttr(name, "validity_days", "365"),
+					resource.TestCheckResourceAttr(name, "validity_days", "90"),
 					resource.TestCheckResourceAttr(name, "certificate_authority", "lets_encrypt"),
 					resource.TestCheckResourceAttr(name, "cloudflare_branding", "false"),
 					resource.TestCheckResourceAttr(name, "wait_for_active_status", "true"),
@@ -126,7 +126,7 @@ resource "cloudflare_certificate_pack" "%[3]s" {
     "%[2]s"
   ]
   validation_method = "txt"
-  validity_days = 365
+  validity_days = 90
   certificate_authority = "lets_encrypt"
   cloudflare_branding = false
   wait_for_active_status = true