Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the use of Additional Cacheable Ports in Cache Rules #2754

Closed

Conversation

iveelsm
Copy link
Contributor

@iveelsm iveelsm commented Sep 11, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

changelog detected ✅

@iveelsm iveelsm force-pushed the mikey/additional-cacheable-ports branch from 677bace to f039733 Compare September 11, 2023 00:59
@jacobbednarz
Copy link
Member

similar to #2755, this PR doesn't include the handling of the API or the state. in the current state, it doesn't do anything new.

@@ -483,6 +483,7 @@ Read-Only:
Optional:

- `algorithms` (Block List) Compression algorithms to use in order of preference. (see [below for nested schema](#nestedblock--rules--action_parameters--algorithms))
- `additional_cacheable_ports` (Set of Int) Specifies additional cacheable ports for use by Origin servers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the documentation is generated automatically based on the schema description (see https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/registry-documentation.md)

@iveelsm iveelsm force-pushed the mikey/additional-cacheable-ports branch 4 times, most recently from dcde674 to c33511d Compare September 14, 2023 05:11
@iveelsm
Copy link
Contributor Author

iveelsm commented Sep 14, 2023

similar to #2755, this PR doesn't include the handling of the API or the state. in the current state, it doesn't do anything new.

Should be ready to rock now.

@iveelsm iveelsm force-pushed the mikey/additional-cacheable-ports branch from c33511d to a0e96dc Compare September 27, 2023 05:13
@jacobbednarz
Copy link
Member

sorry but it still looks like this has issues 😢

=== RUN   TestAccCloudflareRuleset_CacheSettingsOptionalsEmpty
    resource_test.go:1854: Step 1/1 error: Error running apply: exit status 1
        
        Error: Value Conversion Error
        
          with cloudflare_ruleset.tvtqknuzll,
          on terraform_plugin_test.tf line 11, in resource "cloudflare_ruleset" "tvtqknuzll":
          11:       action_parameters {
        
        An unexpected error was encountered while verifying an attribute value
        matched its expected type to prevent unexpected behavior or panics. This is
        always an error in the provider. Please report the following to the provider
        developer:
        
        Expected framework type from provider logic:
        types.SetType[basetypes.Int64Type] / underlying type:
        tftypes.Set[tftypes.Number]
        Received framework type from provider logic: types.SetType[!!! MISSING TYPE
        !!!] / underlying type: tftypes.Set[tftypes.DynamicPseudoType]
        Path: rules[0].action_parameters[0].additional_cacheable_ports

@github-actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@foreseaz
Copy link
Member

@jacobbednarz heya Jacob I'll take over the following tasks, looks I cannot push top of this PR so I created a separated PR here #2854 and passed TestAccCloudflareRuleset_CacheSettingsOptionalsEmpty locally. Feel free to take a look anytime.

And thank Mikey's previous awesome work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants