-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the use of Additional Cacheable Ports in Cache Rules #2754
Add support for the use of Additional Cacheable Ports in Cache Rules #2754
Conversation
changelog detected ✅ |
677bace
to
f039733
Compare
similar to #2755, this PR doesn't include the handling of the API or the state. in the current state, it doesn't do anything new. |
docs/resources/ruleset.md
Outdated
@@ -483,6 +483,7 @@ Read-Only: | |||
Optional: | |||
|
|||
- `algorithms` (Block List) Compression algorithms to use in order of preference. (see [below for nested schema](#nestedblock--rules--action_parameters--algorithms)) | |||
- `additional_cacheable_ports` (Set of Int) Specifies additional cacheable ports for use by Origin servers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the documentation is generated automatically based on the schema description (see https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/registry-documentation.md)
dcde674
to
c33511d
Compare
Should be ready to rock now. |
c33511d
to
a0e96dc
Compare
sorry but it still looks like this has issues 😢
|
Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the |
@jacobbednarz heya Jacob I'll take over the following tasks, looks I cannot push top of this PR so I created a separated PR here #2854 and passed And thank Mikey's previous awesome work :) |
No description provided.