AUTH-5428: added tags as a resource #2776

russellkerns · 2023-09-19T01:20:14Z

associated cf-go PR - cloudflare/cloudflare-go#1403

github-actions · 2023-09-19T01:20:47Z

changelog detected ✅

jacobbednarz · 2023-10-02T02:41:37Z

looks like one of the acceptance tests are failing here.

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^(TestAccCloudflareAccessTag|TestAccCloudflareAccessApplication_)" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessApplication_BasicZone
--- PASS: TestAccCloudflareAccessApplication_BasicZone (15.66s)
=== RUN   TestAccCloudflareAccessApplication_BasicAccount
--- PASS: TestAccCloudflareAccessApplication_BasicAccount (11.12s)
=== RUN   TestAccCloudflareAccessApplication_WithCORS
--- PASS: TestAccCloudflareAccessApplication_WithCORS (10.81s)
=== RUN   TestAccCloudflareAccessApplication_WithSaas
--- PASS: TestAccCloudflareAccessApplication_WithSaas (15.75s)
=== RUN   TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity
--- PASS: TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity (29.38s)
=== RUN   TestAccCloudflareAccessApplication_WithEnableBindingCookie
--- PASS: TestAccCloudflareAccessApplication_WithEnableBindingCookie (14.34s)
=== RUN   TestAccCloudflareAccessApplication_WithCustomDenyFields
--- PASS: TestAccCloudflareAccessApplication_WithCustomDenyFields (10.85s)
=== RUN   TestAccCloudflareAccessApplication_WithADefinedIdps
--- PASS: TestAccCloudflareAccessApplication_WithADefinedIdps (12.91s)
=== RUN   TestAccCloudflareAccessApplication_WithMultipleIdpsReordered
--- PASS: TestAccCloudflareAccessApplication_WithMultipleIdpsReordered (33.88s)
=== RUN   TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute (10.33s)
=== RUN   TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse
--- PASS: TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse (30.84s)
=== RUN   TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute (10.14s)
=== RUN   TestAccCloudflareAccessApplication_WithLogoURL
--- PASS: TestAccCloudflareAccessApplication_WithLogoURL (14.50s)
=== RUN   TestAccCloudflareAccessApplication_WithSkipInterstitial
--- PASS: TestAccCloudflareAccessApplication_WithSkipInterstitial (9.71s)
=== RUN   TestAccCloudflareAccessApplication_WithAppLauncherVisible
--- PASS: TestAccCloudflareAccessApplication_WithAppLauncherVisible (9.48s)
=== RUN   TestAccCloudflareAccessApplication_WithSelfHostedDomains
--- PASS: TestAccCloudflareAccessApplication_WithSelfHostedDomains (9.64s)
=== RUN   TestAccCloudflareAccessApplication_WithDefinedTags
    resource_cloudflare_access_application_test.go:523: Step 1/1 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # cloudflare_access_tag.xrgrcitsab will be updated in-place
          ~ resource "cloudflare_access_tag" "xrgrcitsab" {
              - app_count  = 1 -> null
                id         = "xrgrcitsab"
                name       = "xrgrcitsab"
                # (1 unchanged attribute hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccCloudflareAccessApplication_WithDefinedTags (11.15s)
=== RUN   TestAccCloudflareAccessTag_Basic
--- PASS: TestAccCloudflareAccessTag_Basic (15.12s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	275.950s
FAIL

russellkerns · 2023-10-12T20:58:51Z

looks like one of the acceptance tests are failing here.

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^(TestAccCloudflareAccessTag|TestAccCloudflareAccessApplication_)" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessApplication_BasicZone
--- PASS: TestAccCloudflareAccessApplication_BasicZone (15.66s)
=== RUN   TestAccCloudflareAccessApplication_BasicAccount
--- PASS: TestAccCloudflareAccessApplication_BasicAccount (11.12s)
=== RUN   TestAccCloudflareAccessApplication_WithCORS
--- PASS: TestAccCloudflareAccessApplication_WithCORS (10.81s)
=== RUN   TestAccCloudflareAccessApplication_WithSaas
--- PASS: TestAccCloudflareAccessApplication_WithSaas (15.75s)
=== RUN   TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity
--- PASS: TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity (29.38s)
=== RUN   TestAccCloudflareAccessApplication_WithEnableBindingCookie
--- PASS: TestAccCloudflareAccessApplication_WithEnableBindingCookie (14.34s)
=== RUN   TestAccCloudflareAccessApplication_WithCustomDenyFields
--- PASS: TestAccCloudflareAccessApplication_WithCustomDenyFields (10.85s)
=== RUN   TestAccCloudflareAccessApplication_WithADefinedIdps
--- PASS: TestAccCloudflareAccessApplication_WithADefinedIdps (12.91s)
=== RUN   TestAccCloudflareAccessApplication_WithMultipleIdpsReordered
--- PASS: TestAccCloudflareAccessApplication_WithMultipleIdpsReordered (33.88s)
=== RUN   TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute (10.33s)
=== RUN   TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse
--- PASS: TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse (30.84s)
=== RUN   TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute (10.14s)
=== RUN   TestAccCloudflareAccessApplication_WithLogoURL
--- PASS: TestAccCloudflareAccessApplication_WithLogoURL (14.50s)
=== RUN   TestAccCloudflareAccessApplication_WithSkipInterstitial
--- PASS: TestAccCloudflareAccessApplication_WithSkipInterstitial (9.71s)
=== RUN   TestAccCloudflareAccessApplication_WithAppLauncherVisible
--- PASS: TestAccCloudflareAccessApplication_WithAppLauncherVisible (9.48s)
=== RUN   TestAccCloudflareAccessApplication_WithSelfHostedDomains
--- PASS: TestAccCloudflareAccessApplication_WithSelfHostedDomains (9.64s)
=== RUN   TestAccCloudflareAccessApplication_WithDefinedTags
    resource_cloudflare_access_application_test.go:523: Step 1/1 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # cloudflare_access_tag.xrgrcitsab will be updated in-place
          ~ resource "cloudflare_access_tag" "xrgrcitsab" {
              - app_count  = 1 -> null
                id         = "xrgrcitsab"
                name       = "xrgrcitsab"
                # (1 unchanged attribute hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccCloudflareAccessApplication_WithDefinedTags (11.15s)
=== RUN   TestAccCloudflareAccessTag_Basic
--- PASS: TestAccCloudflareAccessTag_Basic (15.12s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	275.950s
FAIL

Should be fixed!

jacobbednarz · 2023-10-16T03:27:49Z

awesome! all good now.

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^(TestAccCloudflareAccessTag|TestAccCloudflareAccessApplication)_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessApplication_BasicZone
--- PASS: TestAccCloudflareAccessApplication_BasicZone (9.23s)
=== RUN   TestAccCloudflareAccessApplication_BasicAccount
--- PASS: TestAccCloudflareAccessApplication_BasicAccount (9.57s)
=== RUN   TestAccCloudflareAccessApplication_WithCORS
--- PASS: TestAccCloudflareAccessApplication_WithCORS (10.03s)
=== RUN   TestAccCloudflareAccessApplication_WithSaas
--- PASS: TestAccCloudflareAccessApplication_WithSaas (11.03s)
=== RUN   TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity
--- PASS: TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity (11.32s)
=== RUN   TestAccCloudflareAccessApplication_WithEnableBindingCookie
--- PASS: TestAccCloudflareAccessApplication_WithEnableBindingCookie (9.92s)
=== RUN   TestAccCloudflareAccessApplication_WithCustomDenyFields
--- PASS: TestAccCloudflareAccessApplication_WithCustomDenyFields (10.02s)
=== RUN   TestAccCloudflareAccessApplication_WithADefinedIdps
--- PASS: TestAccCloudflareAccessApplication_WithADefinedIdps (11.17s)
=== RUN   TestAccCloudflareAccessApplication_WithMultipleIdpsReordered
--- PASS: TestAccCloudflareAccessApplication_WithMultipleIdpsReordered (26.25s)
=== RUN   TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute (9.70s)
=== RUN   TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse
--- PASS: TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse (9.29s)
=== RUN   TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute (9.73s)
=== RUN   TestAccCloudflareAccessApplication_WithLogoURL
--- PASS: TestAccCloudflareAccessApplication_WithLogoURL (9.27s)
=== RUN   TestAccCloudflareAccessApplication_WithSkipInterstitial
--- PASS: TestAccCloudflareAccessApplication_WithSkipInterstitial (9.86s)
=== RUN   TestAccCloudflareAccessApplication_WithAppLauncherVisible
--- PASS: TestAccCloudflareAccessApplication_WithAppLauncherVisible (9.45s)
=== RUN   TestAccCloudflareAccessApplication_WithSelfHostedDomains
--- PASS: TestAccCloudflareAccessApplication_WithSelfHostedDomains (9.51s)
=== RUN   TestAccCloudflareAccessApplication_WithDefinedTags
--- PASS: TestAccCloudflareAccessApplication_WithDefinedTags (10.68s)
=== RUN   TestAccCloudflareAccessTag_Basic
--- PASS: TestAccCloudflareAccessTag_Basic (7.53s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	194.519s

github-actions · 2023-10-18T03:43:47Z

This functionality has been released in v4.17.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

AUTH-5428: added tags as a resource

9a09107

russellkerns requested a review from jacobbednarz as a code owner September 19, 2023 01:20

russellkerns and others added 2 commits September 18, 2023 20:21

Merge branch 'master' into rkerns/AUTH-5428

63ec85c

updated changelog entry

ee1005f

jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Sep 20, 2023

jacobbednarz added 3 commits October 2, 2023 12:23

Merge branch 'master' into rkerns/AUTH-5428

1ee4e8d

fix lint

24b33d4

include underscore in name for flexibility

4d9724a

Added computed value to app count in tags

9c23206

jacobbednarz merged commit 99178e6 into cloudflare:master Oct 16, 2023
7 of 9 checks passed

github-actions bot added this to the v4.17.0 milestone Oct 16, 2023

github-actions bot pushed a commit that referenced this pull request Oct 16, 2023

Update CHANGELOG.md for #2776

5d61607

jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Oct 17, 2023

jacobbednarz mentioned this pull request Oct 17, 2023

Support for Access application tags #2858

Closed

github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AUTH-5428: added tags as a resource #2776

AUTH-5428: added tags as a resource #2776

russellkerns commented Sep 19, 2023

github-actions bot commented Sep 19, 2023 •

edited

Loading

jacobbednarz commented Oct 2, 2023

russellkerns commented Oct 12, 2023

jacobbednarz commented Oct 16, 2023

github-actions bot commented Oct 18, 2023

AUTH-5428: added tags as a resource #2776

AUTH-5428: added tags as a resource #2776

Conversation

russellkerns commented Sep 19, 2023

github-actions bot commented Sep 19, 2023 • edited Loading

jacobbednarz commented Oct 2, 2023

russellkerns commented Oct 12, 2023

jacobbednarz commented Oct 16, 2023

github-actions bot commented Oct 18, 2023

github-actions bot commented Sep 19, 2023 •

edited

Loading