Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable selector filter and add traffic_anomalies_alert as notification type #2976

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

Adds selector filter
Adds traffic_anomalies_alert for notification policy types (not in the API yet but is valid through dashboard)

Fixes #2935

Copy link
Contributor

github-actions bot commented Dec 2, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

cc @jasoncabot

@jasoncabot
Copy link
Contributor

This looks good to me, thanks for the change. I've also updated the OpenAPI spec too to add traffic_anomalies_alert

@jacobbednarz
Copy link
Member

i fixed up the test assertion here in 0eec700 and now we're looking good!

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareNotificationPolicy_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareNotificationPolicy_Basic
--- PASS: TestAccCloudflareNotificationPolicy_Basic (17.45s)
=== RUN   TestAccCloudflareNotificationPolicy_WithFiltersAttribute
--- PASS: TestAccCloudflareNotificationPolicy_WithFiltersAttribute (17.55s)
=== RUN   TestAccCloudflareNotificationPolicy_WithSelectorsAttribute
--- PASS: TestAccCloudflareNotificationPolicy_WithSelectorsAttribute (10.71s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	46.511s

@jacobbednarz jacobbednarz merged commit 40b1cca into cloudflare:master Dec 13, 2023
9 checks passed
@github-actions github-actions bot added this to the v4.21.0 milestone Dec 13, 2023
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
Copy link
Contributor

This functionality has been released in v4.21.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the notification-selector branch February 3, 2024 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_notification_policy filter selectors not working
3 participants