Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [[pipelines]] binding in wrangler. #6641

Closed
wants to merge 1 commit into from

Conversation

oliy
Copy link
Contributor

@oliy oliy commented Sep 5, 2024

What this PR solves / how to test

PIPE-116 Implement regular [[pipelines]] bindings

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@oliy oliy requested review from a team as code owners September 5, 2024 03:09
Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: 34e12ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@oliy oliy force-pushed the oli/pipeline_binding branch from 7b8bfd0 to 201a162 Compare September 5, 2024 16:48
@lrapoport-cf lrapoport-cf added the caretaking Priority for caretaking label Sep 5, 2024
@oliy oliy force-pushed the oli/pipeline_binding branch from 201a162 to 491a52a Compare September 5, 2024 21:10
@oliy oliy force-pushed the oli/pipeline_binding branch 3 times, most recently from a937f43 to 2f109cb Compare September 6, 2024 21:07
@andyjessop andyjessop added the e2e Run e2e tests on a PR label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10787971718/npm-package-wrangler-6641

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6641/npm-package-wrangler-6641

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10787971718/npm-package-wrangler-6641 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10787971718/npm-package-create-cloudflare-6641 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10787971718/npm-package-cloudflare-kv-asset-handler-6641
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10787971718/npm-package-miniflare-6641
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10787971718/npm-package-cloudflare-pages-shared-6641
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10787971718/npm-package-cloudflare-vitest-pool-workers-6641
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10787971718/npm-package-cloudflare-workers-editor-shared-6641
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10787971718/npm-package-cloudflare-workers-shared-6641

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.75.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.1
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@andyjessop andyjessop mentioned this pull request Sep 9, 2024
12 tasks
@oliy oliy force-pushed the oli/pipeline_binding branch from 2f109cb to 34e12ea Compare September 10, 2024 07:39
@andyjessop andyjessop self-assigned this Sep 11, 2024
@andyjessop
Copy link
Contributor

Closing this as the changes have been added here: #6674

@andyjessop andyjessop closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caretaking Priority for caretaking e2e Run e2e tests on a PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants