Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta tag from r2 event notification wrangler commands #6809

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Remove beta tag from r2 event notification wrangler commands #6809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-years-nail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

fix: Remove Beta tag from r2 event notification wrangler command descriptions
10 changes: 5 additions & 5 deletions packages/wrangler/src/__tests__/r2.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe("r2", () => {
wrangler r2 bucket list List R2 buckets
wrangler r2 bucket delete <name> Delete an R2 bucket
wrangler r2 bucket sippy Manage Sippy incremental migration on an R2 bucket
wrangler r2 bucket notification Manage event notification rules for an R2 bucket [open beta]
wrangler r2 bucket notification Manage event notification rules for an R2 bucket

GLOBAL FLAGS
-j, --experimental-json-config Experimental: support wrangler.json [boolean]
Expand Down Expand Up @@ -130,7 +130,7 @@ describe("r2", () => {
wrangler r2 bucket list List R2 buckets
wrangler r2 bucket delete <name> Delete an R2 bucket
wrangler r2 bucket sippy Manage Sippy incremental migration on an R2 bucket
wrangler r2 bucket notification Manage event notification rules for an R2 bucket [open beta]
wrangler r2 bucket notification Manage event notification rules for an R2 bucket

GLOBAL FLAGS
-j, --experimental-json-config Experimental: support wrangler.json [boolean]
Expand Down Expand Up @@ -902,7 +902,7 @@ describe("r2", () => {
"
wrangler r2 bucket notification list <bucket>

List event notification rules for a bucket [open beta]
List event notification rules for a bucket

POSITIONALS
bucket The name of the R2 bucket to get event notification rules for [string] [required]
Expand Down Expand Up @@ -1008,7 +1008,7 @@ describe("r2", () => {
"
wrangler r2 bucket notification create <bucket>

Create an event notification rule for an R2 bucket [open beta]
Create an event notification rule for an R2 bucket

POSITIONALS
bucket The name of the R2 bucket to create an event notification rule for [string] [required]
Expand Down Expand Up @@ -1165,7 +1165,7 @@ describe("r2", () => {
"
wrangler r2 bucket notification delete <bucket>

Delete an event notification rule from an R2 bucket [open beta]
Delete an event notification rule from an R2 bucket

POSITIONALS
bucket The name of the R2 bucket to delete an event notification rule for [string] [required]
Expand Down
15 changes: 5 additions & 10 deletions packages/wrangler/src/r2/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,10 @@ import * as fs from "node:fs";
import * as path from "node:path";
import * as stream from "node:stream";
import { ReadableStream } from "node:stream/web";
import chalk from "chalk";
import prettyBytes from "pretty-bytes";
import { readConfig } from "../config";
import { FatalError, UserError } from "../errors";
import {
betaCmdColor,
CommandLineArgsError,
printWranglerBanner,
} from "../index";
import { CommandLineArgsError, printWranglerBanner } from "../index";
import { logger } from "../logger";
import * as metrics from "../metrics";
import { requireAuth } from "../user";
Expand Down Expand Up @@ -648,24 +643,24 @@ export function r2(r2Yargs: CommonYargsArgv, subHelp: SubHelp) {

r2BucketYargs.command(
"notification",
`Manage event notification rules for an R2 bucket ${chalk.hex(betaCmdColor)("[open beta]")}`,
"Manage event notification rules for an R2 bucket",
(r2EvNotifyYargs) => {
return r2EvNotifyYargs
.command(
["list <bucket>", "get <bucket>"],
`List event notification rules for a bucket ${chalk.hex(betaCmdColor)("[open beta]")}`,
"List event notification rules for a bucket",
Notification.ListOptions,
Notification.ListHandler
)
.command(
"create <bucket>",
`Create an event notification rule for an R2 bucket ${chalk.hex(betaCmdColor)("[open beta]")}`,
"Create an event notification rule for an R2 bucket",
Notification.CreateOptions,
Notification.CreateHandler
)
.command(
"delete <bucket>",
`Delete an event notification rule from an R2 bucket ${chalk.hex(betaCmdColor)("[open beta]")}`,
"Delete an event notification rule from an R2 bucket",
Notification.DeleteOptions,
Notification.DeleteHandler
);
Expand Down
Loading