-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudchamber: Start cloudchamber apply
, the new command to deploy
#7229
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ba38d17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-wrangler-7229 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7229/npm-package-wrangler-7229 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-wrangler-7229 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-create-cloudflare-7229 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-cloudflare-kv-asset-handler-7229 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-miniflare-7229 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-cloudflare-pages-shared-7229 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-cloudflare-vitest-pool-workers-7229 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-cloudflare-workers-editor-shared-7229 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-cloudflare-workers-shared-7229 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11981995817/npm-package-cloudflare-workflows-shared-7229 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
f3bcfb7
to
649cc88
Compare
Not a blocker: I kind of want a "cloudchamber status" code that can tell me what the status of the apps are in my wrangler.toml and if they're up now/what the diff would be. |
Is there a way to unset tier? Should there be? |
My dream in using this is to be able to somehow output a wrangler.toml configuration with every possible attribute that I might be able to set and have it add comments for what the possible options are. Docs could do this too, but I don't want to have to find them. If you hooked up the plumbing, I could provide the template for this. Not sure what the command would be to do it though "wrangler cloudchamber init --verbose" or something? Maybe linking to the docs for "wrangler apply" from the "-h" command could be generally useful for describing attrs/showing a verbose toml config? |
--json doesn't seem to do anything (at least not on noops or errors) EDIT: When I got the "name" error above, it didn't work, but in some other case it returned json. Unclear when |
Overall, LOVE the overall feel and the workflow, but left some commends - some of which are brainstormy/not blockers. |
I've now gotten into a state where I've made a bunch of apps via the CLI and I can't delete them via the CLI because they're app-driven, so even if I remove the deployments they'll come back to life (I think?). We'll probably need either a "cloudchamber destroy" method that reads from the toml and reverts it all, and/or application CRUD from the CLI. Or maybe some special config to remove an application on next "apply" - thoughts? |
there should definitely be a way to skip defaults for sure |
container app changes This command is able to take the [[container-app]] configurations, and deploy them to Cloudchamber. To render the differences, we are introducing a new dependency with "diff". This was already included in the pnpm lock, however we could consider not rolling out a new dependency into wrangler unless absolutely necessary. The command is designed to be CI friendly. In the tests there is some example command renders from different kind of configurations. One of the biggest TODOs here is proper error rendering. We hope to improve that overtime, and pinpoint to the user in the wrangler.toml what went wrong.
9550737
to
ba38d17
Compare
container app changes
This command is able to take the [[container-app]] configurations, and deploy them to Cloudchamber.
To render the differences, we are introducing a new dependency with "diff". This was already included in the pnpm lock, however we could consider not rolling out a new dependency into wrangler unless absolutely necessary.
The command is designed to be CI friendly. In the tests there is some example command renders from different kind of configurations.
Fixes #[insert GH or internal issue link(s)].
Describe your change...