Skip to content

Commit

Permalink
docs: add docs/testing.md
Browse files Browse the repository at this point in the history
  • Loading branch information
Kehrlann committed Dec 17, 2024
1 parent d3ba14f commit 1da2909
Show file tree
Hide file tree
Showing 2 changed files with 111 additions and 1 deletion.
21 changes: 20 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,14 +209,33 @@ You can run the integration tests with docker

will create a docker container running uaa + ldap + database whereby integration tests are run against.

### Using Gradle to test with postgresql or mysql
### Using Docker to test with postgresql or mysql

The default uaa unit tests (./gradlew test integrationTest) use hsqldb.

To run the unit tests with docker:

$ run-unit-tests.sh <dbtype>

### Using Gradle to test with Postgres or MySQL

You need a locally running database. You can launch a Postgres 15 and MySQL 8 locally with docker compose:

$ docker compose --file scripts/docker-compose.yaml up

If you wish to launch only one of the DBs, select the appropriate service name:

$ docker compose --file scripts/docker-compose.yaml up postgresql

Then run the test with the appropriate profile:

$ ./gradlew '-Dspring.profiles.active=postgresql,default' \
--no-daemon \
test

There are special guarantees in place to avoid pollution between tests, so be sure to run the images
from the compose script, and run your test with `--no-daemon`. To learn more, read [docs/testing.md](docs/testing.md).

### To run a single test

The default uaa unit tests (`./gradlew test`) use hsqldb.
Expand Down
91 changes: 91 additions & 0 deletions docs/testing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
# Testing considerations

This document contains information about how the tests are structured and why.

## Types of test

There are two types of tests:

- Unit tests, which run tests on classes or subsets of the application in a single JVM. Those run with `./gradlew test`.
- Integration tests, which launch the UAA application and run web-based tests the running app. Those can be run with
`./gradlew integrationTest`

There are helper scripts, `run-unit-tests.sh` and `run-integration-tests.sh`, which run the tests inside a docker
container. The docker container they run in contains the database against which to run the tests, as well as an LDAP
server.

## Test databases

By default, the tests run against an in-memory DB, `hsqldb`. This DB is also present in the prod artifact, so that
UAA can also be ran standalone to test tweaks in a live instance.

To run these databases locally, use the docker-compose script:

$ docker compose --file scripts/docker-compose.yaml up

If you wish to launch only one of the DBs, select the appropriate service name:

$ docker compose --file scripts/docker-compose.yaml up postgresql

To run tests against either Postgres or MySQL, use the `postgresql` or `mysql` profile, to select the DB. Be sure
to add the `default` profile which will trigger seeding the database with some admin users, clients, etc. For example:

$ ./gradlew '-Dspring.profiles.active=mysql,default test

## Test pollution

There might be test pollution when tests are run in parallel, or even between projects. For example, when you run

$ ./gradlew test

It will run tests in both `cloudfoundry-identity-server` and `cloudfoundry-identity-uaa` projects. Both need a database,
and both do sometimes clean up the database.

To avoid test pollution, 24 databases are created, and each Gradle "worker" thread gets its own database. A Gradle
worker has a numeric `id`, and each time a new task is spun up, the idea of the worker picking up the task increases.
So there are 24 DBs with names `uaa_1`, `uaa_2`, ... created, and usually the worker ID stays below 24 and there are
enough databases for each test.

However, if the gradle daemon is kept running in the background and is re-used for subsequent tasks, e.g. by doing:

$ ./gradlew test # first run
# do some code changes
$ ./gradlew test

You will get new workers with IDs > 24. It is recommended you run your Gradle in no-daemon mode when running tests:

$ ./gradlew test --no-daemon

It will be slightly slower to start up (a few seconds), but the tests take multiple minutes and so the gain of using
a daemon is not worth the trouble.

## Timezone issues

The UAA and its DB server _MUST_ have the same timezone, because dates are not uniformly stored in UTC and timezones
do matter. Specifically for MySQL, there are issues when your local host is ahead of UTC, because:

1. The default containers runs in UTC
2. When calling `current_timestamp` the value is in UTC
3. But when calling a prepared statement from JDBC with a Date/Timestamp/time-based the timezone is sent to the server

So, when running e.g. in France (CET):

```java
jdbcTemplate.queryForObject("SELECT CURRENT_TIMESTAMP",String .class);
// will return 15:00UTC
// if the TZ is dropped, it is recorded as 15:00
jdbcTemplate.

update("UPDATE foo SET updated=?",new Date(System.currentTimeMillis()));
// will insert 16:00CET
// if the TZ is dropped this is recorded as 16:00
```

For this reason, we update the MySQL container in `docker-compose.yml` to have the same timezone as the host through
the `$TZ` env var.

If you have timing-based issues in your test, ensure that you set `$TZ` before starting docker compose, e.g.:

$ TZ="Europe/Paris" docker compose up

It is not required, and MySQL will default to using UTC.

0 comments on commit 1da2909

Please sign in to comment.