feat: restrict visibility

This is no inheritance of these classes that need the constant to be accessible.
cloudfoundry · Nov 2, 2023 · 583dd6e · 583dd6e
1 parent 74ce740
commit 583dd6e
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 10 deletions.
diff --git a/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/DnsErrorPage.java b/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/DnsErrorPage.java
@@ -7,8 +7,6 @@
 import static org.hamcrest.Matchers.containsString;
 
 public class DnsErrorPage extends Page {
-    static final protected String urlPath = "/";
-
     public DnsErrorPage(WebDriver driver) {
         super(driver);
         validatePageSource(driver, containsString("This site can’t be reached"));

diff --git a/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/HomePage.java b/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/HomePage.java
@@ -8,7 +8,7 @@
 import static org.hamcrest.Matchers.endsWith;
 
 public class HomePage extends Page {
-    static final protected String urlPath = "/";
+    static final private String urlPath = "/";
 
     public HomePage(WebDriver driver) {
         super(driver);

diff --git a/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/LoginPage.java b/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/LoginPage.java
@@ -7,7 +7,7 @@
 
 public class LoginPage extends Page {
 
-    static final protected String urlPath = "/login";
+    static final private String urlPath = "/login";
 
     public LoginPage(WebDriver driver) {
         super(driver);

diff --git a/...src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/LogoutDoEndpoint.java b/...src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/LogoutDoEndpoint.java
@@ -6,7 +6,7 @@
 import org.openqa.selenium.WebDriver;
 
 public class LogoutDoEndpoint extends Page {
-    static final protected String urlPath = "/logout.do";
+    static final private String urlPath = "/logout.do";
 
 
     public LogoutDoEndpoint(WebDriver driver) {

diff --git a/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/PasscodePage.java b/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/PasscodePage.java
@@ -8,7 +8,7 @@
 import static org.junit.Assert.assertThat;
 
 public class PasscodePage extends Page {
-    static final protected String urlPath = "/passcode";
+    static final private String urlPath = "/passcode";
 
     public PasscodePage(WebDriver driver) {
         super(driver);

diff --git a/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/SamlErrorPage.java b/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/SamlErrorPage.java
@@ -6,7 +6,7 @@
 import static org.hamcrest.Matchers.endsWith;
 
 public class SamlErrorPage extends Page {
-    static final protected String urlPath = "/saml_error";
+    static final private String urlPath = "/saml_error";
 
     public SamlErrorPage(WebDriver driver) {
         super(driver);

diff --git a/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/SamlLoginPage.java b/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/SamlLoginPage.java
@@ -8,7 +8,7 @@
 
 public class SamlLoginPage extends Page {
     // This is on the saml server, not the UAA server
-    static final protected String urlPath = "/module.php/core/loginuserpass";
+    static final private String urlPath = "/module.php/core/loginuserpass";
 
     public SamlLoginPage(WebDriver driver) {
         super(driver);

diff --git a/...a/org/cloudfoundry/identity/uaa/integration/pageObjects/SamlLogoutAuthSourceEndpoint.java b/...a/org/cloudfoundry/identity/uaa/integration/pageObjects/SamlLogoutAuthSourceEndpoint.java
@@ -9,7 +9,7 @@
 import static org.hamcrest.Matchers.endsWith;
 
 public class SamlLogoutAuthSourceEndpoint extends Page {
-    static final protected String urlPath = "/module.php/core/logout";
+    static final private String urlPath = "/module.php/core/logout";
 
     public SamlLogoutAuthSourceEndpoint(WebDriver driver) {
         super(driver);

diff --git a/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/SamlWelcomePage.java b/uaa/src/test/java/org/cloudfoundry/identity/uaa/integration/pageObjects/SamlWelcomePage.java
@@ -8,7 +8,7 @@
 import static org.hamcrest.Matchers.endsWith;
 
 public class SamlWelcomePage extends Page {
-    static final protected String urlPath = "module.php/core/welcome";
+    static final private String urlPath = "module.php/core/welcome";
 
     public SamlWelcomePage(WebDriver driver) {
         super(driver);