Add label text to all form controls #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, placeholder text has been used to represent the label for form controls. This allows visual users to tell what content to enter in specific form controls. However, screen readers generally expect an explicit label to be associated with form controls. Rather redesign all pages to add `<label>` elements for each control, this adds the `aria-label` attribute to each form control. This should allow screen readers to properly announce controls as the page is read.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/186402859 The labels on this github issue will be updated when the story is started. |
|
@Tallicia can you retrigger concourse ? |
|
It looks like these need to be created with local braches in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, placeholder text has been used to represent the label for form controls. This allows visual users to tell what content to enter in specific form controls. However, screen readers generally expect an explicit label to be associated with form controls.
Rather redesign all pages to add
<label>elements for each control, this adds thearia-labelattribute to each form control. This should allow screen readers to properly announce controls as the page is read.