tests: enable parallel testing to speed up database-backed tests #3203
+71
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kehrlann
force-pushed
the
dgarnier/parallel-tests
branch
2 times, most recently
from
c3c2487 to
e5c8a79
Compare
mamachanko
reviewed
Dec 19, 2024
server/src/main/java/org/cloudfoundry/identity/uaa/db/UaaDatabaseName.java
Outdated
Show resolved
Hide resolved
Kehrlann
force-pushed
the
dgarnier/parallel-tests
branch
from
e5c8a79 to
afa6a9f
Compare
- Now that we have re-enabled DB testing with cloudfoundrygh-3186, Postgres and MySQL tests are slower, and it is useful to enable some level of parallelism.
Kehrlann
force-pushed
the
dgarnier/parallel-tests
branch
from
afa6a9f to
666b1d0
Compare
strehle
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now that we have re-enabled DB testing with gh-3186, Postgres and MySQL tests are slower, and it is useful to enable some level of parallelism.
Please pay attention to
docs/testing.md, to ensure the explanations are clear.Results
On my mac M1, this speeds up the tests, from around 13 minutes to under 5 minutes for MySQL.
HSQL-based unit tests are only marginally faster.
Blockers
Blocked by gh-3202 ; as some LDAP tests fail when running in parallel.