* Fixed errors and warning messages about ELB Logs S3 bucket

[aleksandarknezevic]

what

• Introduces using cloudposse s3-bucket module for creating ALB logging bucket
• Introducing new variable which defines if s3 logs for ALB is enabled or disabled (default is still true)
• Adding random suffix to the name of logging bucket (since names of S3 must be globally unique - very often name provided in module is in collision with some already existed)
• If created, S3 bucket for storing ALB access logs is encrypted by default
• Updated examples (modules vpc, subnet and alb were in old versions)

why

• This module not usable anymore due to deprecation message by terraform about s3 bucket (see Terraform plan failing for creating S3 elb log and CreateApplicationInput.ApplicationName #227 )
• Users of this module don't always need access logs from Load Balancer n S3 bucket
• Existing examples were unusable due to old versions of modules in them.

references

• closes Terraform plan failing for creating S3 elb log and CreateApplicationInput.ApplicationName #227
• closes Resolve Argument Deprecation Warnings #226
• closes module throws errors when using with aws 4.0 provider #206
• closes Add variable to disable S3 eb-loadbalancer-logs #152

[aknysh]

@aleksandarknezevic thanks for the PR.
Please review and fix the status checks above (terraform fmt the module and example, version pinning, etc.)
Then run the following commands locally and commit the changes:

make init
make github/init
make readme

[aknysh]

please see comments

[aleksandarknezevic]

@aknysh Thank you for suggestions. I solved mentioned problems. You can see my local run here. Second validate fails due to missing ACCESS_TOKEN or APP_ID which is expected on my github. Could we re-run it please?

[aknysh]

@aleksandarknezevic thanks for the updates, looks good

Please see the comment

[aknysh]

@aleksandarknezevic thanks again for all the work on the PR.
Please fix https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/actions/runs/5417366681/jobs/9848261046?pr=243 by running

make init
make github/init
make readme

[aleksandarknezevic]

@aknysh Fixed and squashed. Here is run on my env. Could you please re-run it?

[aknysh]

/terratest

[aknysh]

/terratest

[aleksandarknezevic]

It looks like terratest run using terraform 0.15, we would need at least terraform 1.3.0 here.

+ [[ -n main ]]
+ VERSION=0.15
+ echo Full version to use is 0.15.5, setting VERSION to 0.15
Full version to use is 0.15.5, setting VERSION to 0.15

Is it possible to force terratest to use another version of terraform?

[aknysh]

added the terraform-1.x

added the terraform-1.x label

[aleksandarknezevic]

added the terraform-1.x

added the terraform-1.x label

Not sure if label is enough. Last run used terraform 0.15 as well.

[aknysh]

@aleksandarknezevic sorry again :)

please update terraform version in the module and ALL the examples:

https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/blob/main/versions.tf
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/blob/main/examples/complete/versions.tf
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/blob/main/examples/nlb/versions.tf
https://github.com/cloudposse/terraform-aws-elastic-beanstalk-environment/blob/main/examples/shared-alb/versions.tf

to use

terraform {
  required_version = ">= 1.3.0"

since the updated modules require that version.

also run

make init
make readme

after that

Thanks

[aleksandarknezevic]

@aknysh Thank you. Done. Could you please re-run actions?

[aknysh]

/terratest

[aknysh]

thanks @aleksandarknezevic