Bugfix issue with ALB bucket output name and name in general #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-niland
reviewed
Sep 1, 2023
main.tf
Outdated
| @@ -1103,7 +1103,7 @@ module "elb_logs" { | |||
| source = "cloudposse/lb-s3-bucket/aws" | |||
| version = "0.19.0" | |||
| enabled = var.enable_loadbalancer_logs && local.enabled && var.tier == "WebServer" && var.environment_type == "LoadBalanced" && var.loadbalancer_type != "network" && !var.loadbalancer_is_shared ? true : false | |||
| name = "${module.this.id}-alb-logs-${random_string.elb_logs_suffix.result}" | |||
| name = var.s3_bucket_access_log_bucket_name != "" ? var.s3_bucket_access_log_bucket_name : "${module.this.id}-alb-logs-${random_string.elb_logs_suffix.result}" | |||
There was a problem hiding this comment.
I think the output and the resource name should use a local so they're reading from the same value.
outputs.tf
Outdated
| @@ -84,7 +84,7 @@ output "load_balancers" { | |||
| } | |||
|
|
|||
| output "load_balancer_log_bucket" { | |||
| value = var.enable_loadbalancer_logs ? "${module.this.id}-eb-loadbalancer-logs-${random_string.elb_logs_suffix.result}" : null | |||
| value = var.s3_bucket_access_log_bucket_name != "" ? var.s3_bucket_access_log_bucket_name : "${module.this.id}-alb-logs-${random_string.elb_logs_suffix.result}" | |||
There was a problem hiding this comment.
Do you think the output should output the log bucket name event when logging is disabled?
gugaiz
force-pushed
the
fix_bucket_output_name
branch
from
47b2642
to
d2c4009
Compare
|
/terratest |
joe-niland
added
patch
joe-niland
approved these changes
Sep 7, 2023
|
Thanks for your contribution @gugaiz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This fixes the issue with the output of the ALB bucket name, it also incorporates the option to manually set the bucket name to make it backward compatible with the previous deployment (what already has the bucket name assigned)
why
Because it is a bug that is on production code as commented on here