Support SSL/TLS Connections for Oracle #19
Conversation
One of the unit test case is failing but not specifically because of the new parameter. It is a negative test scenario which tests connection failure,I think it is failing because we are specifying protocol as tcp explicitly now. Looking into it. |
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConnectorConfig.java
Show resolved
Hide resolved
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConnectorConfig.java
Outdated
Show resolved
Hide resolved
Vipinofficial11
force-pushed
the
enableSSLConnections
branch
from
01d2ae8
to
ae059c4
Compare
Fixed the unit tests with minor changes in Connection String's format, tested the changes on CDAP for Source Plugin. [ae059c4] Connection String - |
| } | ||
|
|
||
| // For TNS Descriptor we can't specify the protocol in connection string. | ||
| if (OracleConstants.TNS_CONNECTION_TYPE.equalsIgnoreCase(connectionType)) { |
There was a problem hiding this comment.
see if we can convert it into swtich statement as in general either of the statements will be true. So, we can avoid the compiler navigation to multiple conditional statements.
There was a problem hiding this comment.
Converted to switch [6c60d2d]
oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConstants.java
Outdated
Show resolved
Hide resolved
Vipinofficial11
force-pushed
the
enableSSLConnections
branch
4 times, most recently
from
b9bf75f
to
ae5d1c9
Compare
Vipinofficial11
force-pushed
the
enableSSLConnections
branch
from
ae5d1c9
to
e9dd995
Compare
No description provided.