-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #12
Bugfix #12
Conversation
@@ -45,9 +45,10 @@ public class SuccessFactorsPluginConfig extends PluginConfig { | |||
private static final String REFERENCE_NAME = "referenceName"; | |||
private static final String REFERENCE_NAME_DESCRIPTION = "This will be used to uniquely identify this source/sink " + | |||
"for lineage, annotating metadata, etc."; | |||
private static final String ASSOCIATED_ENTITY_NAME = "associatedEntityName"; | |||
public static final String ASSOCIATED_ENTITY_NAME = "associatedEntityName"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we using public instead of private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be public as used in other classes as well.
@@ -38,6 +39,7 @@ public enum ResourceConstants { | |||
ERR_CHECK_ADVANCED_PARAM(null, "err.check.advanced.parameter"), | |||
ERR_NOT_FOUND(null, "err.resource.not.found"), | |||
ERR_NO_COLUMN_FOUND(null, "err.no.column.found"), | |||
ERR_UNSUPPORTED_ASSOCIATEDENTITY(null, "err.unsupported.associatedEntity"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERR_UNSUPPORTED_ASSOCIATEDENTITY, this can be renamed to ERR_UNSUPPORTED_ASSOCIATED_ENTITY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
also update the value to err.unsupported.associated.entity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -38,6 +39,7 @@ public enum ResourceConstants { | |||
ERR_CHECK_ADVANCED_PARAM(null, "err.check.advanced.parameter"), | |||
ERR_NOT_FOUND(null, "err.resource.not.found"), | |||
ERR_NO_COLUMN_FOUND(null, "err.no.column.found"), | |||
ERR_UNSUPPORTED_ASSOCIATEDENTITY(null, "err.unsupported.associatedEntity"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
also update the value to err.unsupported.associated.entity
private static final String NAME_SCHEMA = "schema"; | ||
private static final String PAGINATION_TYPE = "paginationType"; | ||
public static final String EXPAND_OPTION = "expandOption"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally these variables should be only for internal use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But these are used in other classes as well.
if (SuccessFactorsUtil.isNullOrEmpty(getExpandOption()) && !containsMacro(EXPAND_OPTION)) { | ||
failureCollector.addFailure(ResourceConstants.ERR_INVALID_ENTITY_CALL.getMsgForKey(), null); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -30,6 +31,8 @@ err.missing.dataservice.version=No data service version number found. Please ens | |||
|
|||
## SAP SuccessFactors - metadata processing related messages | |||
err.no.column.found=''{0}'' not found in the ''{1}'' entity. | |||
err.unsupported.associatedEntity=''{0}'' not found in the ''{1}'' entity. Please ensure that associated entity is correct. Please check the property name in Admin Center > OData API Data Dictionary or entity metadata. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message can be refactored as
'{0}'' not found in the ''{1}'' entity. Please ensure that the associated entity is correct or check the property name in Admin Center > OData API Data Dictionary or entity metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
pom.xml
Outdated
@@ -20,7 +20,7 @@ | |||
|
|||
<groupId>io.cdap.plugin.successfactors</groupId> | |||
<artifactId>successfactors-plugins</artifactId> | |||
<version>1.2.0-SNAPSHOT</version> | |||
<version>1.2.2-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove version change from pom file
0473cd3
to
0167131
Compare
d56c4cc
to
552f281
Compare
Bugfix for https://cloudsufi.atlassian.net/browse/CSM-1556