Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gRPC): support gRPC graceful shutdown #1556

Merged
merged 5 commits into from
Nov 22, 2024
Merged

feat(gRPC): support gRPC graceful shutdown #1556

merged 5 commits into from
Nov 22, 2024

Conversation

DMwangnima
Copy link
Contributor

@DMwangnima DMwangnima commented Sep 19, 2024 •
edited by GuangmingLuo
Loading

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

支持 gRPC 优雅退出

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes: #909

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners September 19, 2024 01:23
@DMwangnima DMwangnima force-pushed the feat/grpc_graceful_shutdown branch 3 times, most recently from b2792fa to 67b4624 Compare September 19, 2024 12:05
@DMwangnima DMwangnima changed the title [WIP] feat(gRPC): support gRPC graceful shutdown feat(gRPC): support gRPC graceful shutdown Sep 19, 2024
@DMwangnima DMwangnima force-pushed the feat/grpc_graceful_shutdown branch 4 times, most recently from 119c886 to f2a629f Compare October 14, 2024 09:16
@DMwangnima DMwangnima force-pushed the feat/grpc_graceful_shutdown branch 3 times, most recently from 037ea66 to ac14f37 Compare November 18, 2024 02:06
xiaost
xiaost reviewed Nov 18, 2024
View reviewed changes
pkg/remote/trans/nphttp2/grpc/http2_client.go Outdated Show resolved Hide resolved
pkg/remote/trans/nphttp2/grpc/http2_client.go Outdated Show resolved Hide resolved
pkg/remote/trans/nphttp2/grpc/http2_client.go Show resolved Hide resolved
pkg/remote/trans/nphttp2/grpc/http2_server.go Show resolved Hide resolved
pkg/remote/trans/nphttp2/grpc/http2_server.go Show resolved Hide resolved
pkg/remote/trans/nphttp2/grpc/http2_server.go Outdated Show resolved Hide resolved
pkg/remote/trans/nphttp2/grpc/http2_server.go Outdated Show resolved Hide resolved
pkg/remote/trans/nphttp2/grpc/transport.go Outdated Show resolved Hide resolved
pkg/remote/trans/nphttp2/server_handler.go Outdated Show resolved Hide resolved
@DMwangnima DMwangnima force-pushed the feat/grpc_graceful_shutdown branch 2 times, most recently from 3186d20 to d68c419 Compare November 20, 2024 08:31
@DMwangnima DMwangnima force-pushed the feat/grpc_graceful_shutdown branch 2 times, most recently from af32a56 to 103ad65 Compare November 21, 2024 05:50
@DMwangnima DMwangnima merged commit f268ac9 into cloudwego:develop Nov 22, 2024
19 checks passed
@DMwangnima DMwangnima deleted the feat/grpc_graceful_shutdown branch November 22, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppzqh ppzqh ppzqh approved these changes

@xiaost xiaost xiaost approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc不支持GracefulShutdown?
3 participants
@DMwangnima @xiaost @ppzqh