Merge pull request #19 from clue-labs/nullable

Improve PHP 8.4+ support by avoiding implicitly nullable types
clue · Aug 6, 2024 · 9c78a04 · 9c78a04
2 parents 13e40f8 + 47a7b22
commit 9c78a04
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Clue/Redis/Protocol/Model/MultiBulkReply.php b/src/Clue/Redis/Protocol/Model/MultiBulkReply.php
@@ -19,8 +19,11 @@ class MultiBulkReply implements ModelInterface
      * @param array|null $data
      * @throws InvalidArgumentException
      */
-    public function __construct(array $data = null)
+    public function __construct($data = null)
     {
+        if ($data !== null && !is_array($data)) { // manual type check to support legacy PHP < 7.1
+            throw new InvalidArgumentException('Argument #1 ($data) expected array|null');
+        }
         $this->data = $data;
     }
 

diff --git a/tests/Model/MultiBulkReplyTest.php b/tests/Model/MultiBulkReplyTest.php
@@ -11,6 +11,12 @@ protected function createModel($value)
         return new MultiBulkReply($value);
     }
 
+    public function testConstructWithInvalidDataThrows()
+    {
+        $this->setExpectedException('InvalidArgumentException', 'Argument #1 ($data) expected array|null');
+        new MultiBulkReply('data');
+    }
+
     public function testEmptyArray()
     {
         $model = $this->createModel(array());