Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some documentation about using sccache with this image #147

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

cbeck88
Copy link
Contributor

@cbeck88 cbeck88 commented Jun 7, 2024

as requested (#144 (review)), here's some docu about using sccache

let me know if this looks okay to you. thanks

Copy link
Owner

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, great and cohesive e2e guide. thank you very much. i really appreciate it.

this largely tracks with my expectations, so excited to try this out myself and see. happy to send this out as-is.

Comment on lines +127 to +128
On a mac, docker works differently, so if you are using the example command there, the files won't actually be owned by root, and also the `chown` command will be very slow. So on mac it is better to either skip
the `POST_BUILD_CMD`, or you could modify it so that it actually tests if we are root before doing the `chown`.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, TIL. guess that's what i get for never bothering to test mac.

@cbeck88
Copy link
Contributor Author

cbeck88 commented Jun 7, 2024

actually there's some more stuff i was just reading about, apparently you can try to make sccache talk directly the github actions cache api instead of using a local directory to store and retrieve artifacts:

https://github.com/mozilla/sccache/blob/main/docs/GHA.md

then there are various improvements people made to avoid getting rate limited...

mozilla/sccache#2142
Mozilla-Actions/sccache-action#50

i haven't used any of this before. probably those who need it will find it on their own, i'm not having any problems with the setup i described here anyways

@clux
Copy link
Owner

clux commented Jun 9, 2024

actually there's some more stuff

yeah, all of that also sounds useful, i also have not tried these.
if anyone wants to contribute useful links to working setups / pointers or such in the future, that would be welcome.

in the meantime, merging this. thanks again!

@clux clux merged commit 27c5aeb into clux:main Jun 9, 2024
2 of 6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants