Mounts: Fix issues with vehicles and flying mounts #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killerwife
reviewed
Jan 3, 2025
killerwife
reviewed
Jan 3, 2025
insunaa
force-pushed
the
mountweirdness
branch
from
76e599f to
b336ecf
Compare
insunaa
commented
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR fixes a crash in Vehicle code that is caused by the vehicleInfo being destroyed before UnBoard is called, with UnBoard necessarily referencing vehicleInfo, which is its parent.
This PR also ensures that flying mounts have their speed properly updated. Don't ask my why it wasn't before.