-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: publish to JSR #55
Conversation
.github/workflows/publish.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will run on every commit to master
. However, it'll only ever actually publish to JSR when the value of the version
field in the deno.json
file changes. In other words, it'll do nothing if that value doesn't change.
deno.json
Outdated
@@ -1,9 +1,17 @@ | |||
{ | |||
"name": "@cmd-johnson/deno-oauth2-client", | |||
"version": "1.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be 2.0.0
as this PR makes the package no longer available via HTTP import specifiers.
"https://deno.land/x/oauth2_client/": "./" | ||
}, | ||
"tasks": { | ||
"check:types": "deno check **/*.ts", | ||
"test": "deno test --parallel --trace-leaks --doc" | ||
} | ||
}, | ||
"exports": "./mod.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means @cmd-johnson/deno-oauth2-client
is the only entry point. Alternatively, we could also include more specific modules. E.g.:
@cmd-johnson/deno-oauth2-client/errors
@cmd-johnson/deno-oauth2-client/pkce
@cmd-johnson/deno-oauth2-client/refresh-token-grant
@iuioiua I rebased the PR onto the updated The package is now available at JSR! I'll also try to find some time to test the package with some other runtimes to see if I can get that JSR score closer towards 100% :) |
Ah, this also resolves #52 |
This PR makes this package publishable on JSR. This means that the module will no longer be available on https://deno.land/x and the corresponding workflow should be removed.
Further reading: https://jsr.io/docs/publishing-packages