Feat/code editor #64
Closed
Feat/code editor #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for giffium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
cmgriffing
reviewed
Nov 3, 2024
| @@ -51,6 +46,7 @@ import { toast } from 'solid-sonner' | |||
| import { Separator } from './ui/separator' | |||
| import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from './ui/select' | |||
| import { Accordion, AccordionContent, AccordionItem, AccordionTrigger } from './ui/accordion' | |||
| import ShikiCodeBlock from './ui/shiki-code-block' | |||
There was a problem hiding this comment.
The .ui/ directory is only for generated components from SolidUI. Go ahead and move this up one level.
cmgriffing
reviewed
Nov 3, 2024
| "solid-color": "^0.0.4", | ||
| "solid-icons": "^1.1.0", | ||
| "solid-js": "^1.9.1", | ||
| "solid-shiki-textarea": "^0.1.6", |
There was a problem hiding this comment.
I'm not sure this dependency is being used anymore.
|
Any updates on this? |
Merged
|
This PR has been hanging a bit. I ended fixing the merge conflict and my comments on this PR in a new PR #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #57