Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON parse error: Invalid value. at offset <number> #247

Closed
nsmith- opened this issue Jul 1, 2024 · 1 comment · Fixed by #248
Closed

JSON parse error: Invalid value. at offset <number> #247

nsmith- opened this issue Jul 1, 2024 · 1 comment · Fixed by #248
Labels
bug Something isn't working evaluator Issues related to the evaluator

Comments

@nsmith-
Copy link
Collaborator

nsmith- commented Jul 1, 2024

This is an error caused by removing (in #242) the code to handle float infinities (introduced in #85) as requested in #208.
This becomes effectively a breaking change because existing json may have been written using e.g.

"edges": [
    15.0,
    20.0,
    25.0,
    30.0,
    40.0,
    50.0,
    60.0,
    120.0,
    Infinity
]

What we should do is allow but warn on use of these, as is done in the schema validator.

@nsmith- nsmith- added bug Something isn't working evaluator Issues related to the evaluator labels Jul 1, 2024
@nsmith-
Copy link
Collaborator Author

nsmith- commented Jul 1, 2024

See https://gitlab.cern.ch/cms-nanoAOD/jsonpog-integration/-/merge_requests/79 for work to update centrally-produced json to use string infinity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working evaluator Issues related to the evaluator
Development

Successfully merging a pull request may close this issue.

1 participant