Re-enable rapidjson::kParseNanAndInfFlag for backwards-compatibility #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the evaluator can continue to read json produced pre-v2.6 The schema validator will continue to test for float infinity and warn to migrate to string infinity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so the evaluator can continue to read json produced pre-v2.6 The schema validator will continue to test for float infinity and warn to migrate to string infinity.
The alternative would be to migrate all json to string infinity, but that would not be readable by older evaluators, which is more of a usability issue than the lack of standards-compliance in old json files, for now.
Closes #247