Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of Millepede production system (backport of PR #47080 to 14_2_X) #47081

Open
wants to merge 1 commit into
base: CMSSW_14_2_X
Choose a base branch
from

Conversation

rmankel
Copy link
Contributor

@rmankel rmankel commented Jan 10, 2025

PR description:

The Millepede production system (MPS) is updated. The main improvements are:

  • support for large campaigns (Njobs>999)
  • speedup of job setup
  • improved diagnostics of job output and failure modes
  • fixed issues with job statistics (time...)

The changes have been detailed in the following presentation: https://indico.cern.ch/event/1363492/#26-update-for-the-millepede-pr

PR validation:

Code checks. Code format. Unit tests done.
The changes concern only python scripts that are used exclusively by the MPS system. They are not used by any other code in CMS.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of PR #47080 to 14_2_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2025

A new Pull Request was created by @rmankel for CMSSW_14_2_X.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@adewit, @mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2025

cms-bot internal usage

@perrotta
Copy link
Contributor

backport of #47080

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29eca3/43748/summary.html
COMMIT: 0fc1b52
CMSSW: CMSSW_14_2_X_2025-01-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47081/43748/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 39 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 1900
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3481802
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants