Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add format_header #549

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

infdahai
Copy link

@infdahai infdahai commented Mar 24, 2023

this pr's target is to solve issue #281 .

@infdahai
Copy link
Author

and we should use this header template.

//===----------------------------------------------------------------------===//
//
//                         BusTub
//
// rid.h
//
// Identification: src/include/common/rid.h
//
// Copyright (c) 2015-2019, Carnegie Mellon University Database Group
//
//===----------------------------------------------------------------------===//

@skyzh
Copy link
Member

skyzh commented Mar 25, 2023

You don't need to replace all headers now. We will need to manually apply it to the private repo. As long as the script works, then I'm happy to get it merged.

@infdahai
Copy link
Author

infdahai commented Mar 25, 2023

I guess the format_header py can insert some place and then execute the commands like 'make project2'

@infdahai infdahai changed the title [feat] add format_header feat: add format_header Mar 26, 2023
1. still incomplete file.

Signed-off-by: clundro <clusternlh@gmail.com>
Signed-off-by: clundro <clusternlh@gmail.com>
Signed-off-by: clundro <clusternlh@gmail.com>
Signed-off-by: clundro <clusternlh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants