Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): ensure compatibility std::uniform_int_distribution for binary data generation & improve overall format #587

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix(test): ensure compatibility std::uniform_int_distribution for binary data generation & improve overall format #587

merged 2 commits into from
Aug 11, 2023

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Jul 19, 2023 •
edited
Loading

This PR solves #585 by changing the instantiation of std::uniform_int_distribution from the implicit char to the explicit int, which makes the static_assert in MacOSX13.3.sdk happy. (Detailed reason is mentioned in the issue)
Also improve the overall format for this test🥰

@skyzh skyzh merged commit df2976d into cmu-db:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzhseh @skyzh