Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backward-cpp for backtrace #595

Merged
merged 2 commits into from
Aug 26, 2023
Merged

add backward-cpp for backtrace #595

merged 2 commits into from
Aug 26, 2023

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Aug 24, 2023

close #548

This PR adds backtrace for calls to std::terminate for test cases. This will be called in a variety of cases, like BUSTUB_ENSURE and many other places in the std library. Hopefully this will make debugging easier for students.

On macOS, it cannot show the exact line number of stacktrace due to lack of dwarf support (need libunwind?). On Linux, it will show the full context.

@skyzh skyzh requested a review from yliang412 August 24, 2023 18:57
Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature to have for the students!

Signed-off-by: Alex Chi <iskyzh@gmail.com>

fix clang-tidy

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh merged commit 438d855 into master Aug 26, 2023
3 checks passed
@skyzh skyzh deleted the skyzh/backtrace branch August 26, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants